Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGINT handler is not killing process #1798

Closed
fastmx opened this issue Jan 4, 2017 · 2 comments
Closed

SIGINT handler is not killing process #1798

fastmx opened this issue Jan 4, 2017 · 2 comments

Comments

@fastmx
Copy link
Contributor

fastmx commented Jan 4, 2017

The problem

When i setup webdriver.io with gulp watch and interrupt process with ctrl+c it's not closing.

Environment

  • WebdriverIO version: v4.5.2

  • Node.js version: v4.4.5 (v6 too)

  • Standalone mode or wdio testrunner: jasmine testrunner

  • if wdio testrunner, running synchronous or asynchronous tests: asynchronous

  • Additional wdio packages used (if applicable):

    "wdio-dot-reporter": "0.0.6",
    "wdio-jasmine-framework": "^0.2.19",
    "wdio-selenium-standalone-service": "0.0.7",
    "gulp-webdriver": "^2.0.3",

Link to Selenium/WebdriverIO logs

[12:56:45] Finished 'e2e:run' after 16 s
[12:56:45] Finished 'e2e:dev' after 17 s
then on cmd + c click:

End selenium sessions properly ...
(press crtl+c again to hard kill the runner)

Killing process, bye! (on cmd + c click)
Killing process, bye! (on cmd + c click)
Killing process, bye! (on cmd + c click)
Killing process, bye! (on cmd + c click)

Code To Reproduce Issue [ Good To Have ]

  1. Setup gulp
    gulp.task('e2e:run', function () {
    return gulp.src(config.e2e.config).pipe(webdriver({
    baseUrl: 'http://localhost:' + config.e2e.port,
    specs: config.e2e.specs
    })).on('error', handleErrors);
    });

// production release of player
gulp.task('e2e:dev', function() {
gulp.watch(config.e2e.specs, ['e2e:run']);
});

  1. Run e2e:run task. Everything works like a charm
  2. Run e2e:dev which is watching files
  3. Interrupt (ctrl + c/cmd+c) twice
  4. Gulp process is not killed

Details

I would guess something is wrong with logic here

return this.resolve(1)

Perhaps process.exit is not being called.

@christian-bromann
Copy link
Member

This issue was moved to webdriverio-boneyard/gulp-webdriver#56

@christian-bromann
Copy link
Member

Moved to gulp-webdriver project.

@webdriverio webdriverio locked and limited conversation to collaborators Jan 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants