Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wdio-allure-reporter] Unable to attach buffer content type as a 'image/png' to allure report #6053

Closed
jaworsmi opened this issue Oct 29, 2020 · 1 comment · Fixed by #6061
Labels

Comments

@jaworsmi
Copy link

jaworsmi commented Oct 29, 2020

static addAttachment = (name, content, type = 'application/json') => {
if (typeof content === 'string' || Buffer.isBuffer(content)) {
type = 'text/plain'

All kind of buffer content types (like screenshots created in wdio) are handed as a 'text/plain' due to changes made in #6022

@jaworsmi jaworsmi changed the title Unable to attach buffer content type as a 'image/png' to allure report [wdio-allure-reporter] Unable to attach buffer content type as a 'image/png' to allure report Oct 29, 2020
@christian-bromann christian-bromann added Bug 🐛 help wanted Issues that are free to take by anyone interested labels Oct 29, 2020
@mgrybyk
Copy link
Member

mgrybyk commented Nov 2, 2020

Fixing it.
Adding unit tests already

@mgrybyk mgrybyk self-assigned this Nov 2, 2020
@mgrybyk mgrybyk removed the help wanted Issues that are free to take by anyone interested label Nov 2, 2020
@mgrybyk mgrybyk closed this as completed Nov 2, 2020
@mgrybyk mgrybyk removed their assignment Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants