Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

touchAction has wrong return typescript type void instead of Promise<void> #7350

Closed
vitalyiegorov opened this issue Aug 27, 2021 · 1 comment
Closed

touchAction has wrong return typescript type void instead of Promise<void> #7350

vitalyiegorov opened this issue Aug 27, 2021 · 1 comment
Labels
Bug 🐛 good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript

Comments

@vitalyiegorov
Copy link

vitalyiegorov commented Aug 27, 2021 •
edited

Environment (please complete the following information):

  • WebdriverIO version: 7.11.0
  • Mode: WDIO Testrunner
  • If WDIO Testrunner, running sync/async: sync
  • Node.js version: 16.1.0
  • NPM version: 7.11.2

Describe the bug
touchAction(..) has wrong return typescript type void instead of Promise<void>, this throws errors in sync mode when you try to call await browser.touchAction(..).

Affects both browser and element types
@vitalyiegorov vitalyiegorov changed the title touchAction has wrong asd touchAction has wrong return typescript type void instead of Promise<void> Aug 27, 2021
@christian-bromann christian-bromann added Bug 🐛 good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript labels Aug 27, 2021
@christian-bromann
Copy link
Member

Thanks for filing the issue. Please get involved and provide a fix. Any contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitalyiegorov @christian-bromann