Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(junit-reporter) Include all parent suites in suite.fullTitle #7357

Merged
merged 9 commits into from
Aug 30, 2021
Merged

Conversation

lthurr
Copy link
Contributor

@lthurr lthurr commented Aug 29, 2021

Proposed changes

This is meant to fix #7132 and #5882
It will produce the following xml in junit, when having nested suites

<testcase classname="browser.Suite.Inner_suite.test_1" name="test 1" time="..."/>

About the changes:

I had to modify mocha and jasmine message formatters in order to calculate all parent suites titles/description and join them by a dot ".", required to solve #7132

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 29, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 LGTM

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 30, 2021
@christian-bromann christian-bromann merged commit 07672da into webdriverio:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amend JUnit reporter for better test cases grouping
2 participants