Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use expect in async mode in Jasmine #7458

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

See changes: https://github.com/webdriverio/expect-webdriverio/pull/545/files

This will improve and consolidate tests run with Jasmine. No expectAsync anymore. Just expect.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Internal 🏠 PRs that contain changes internals label Sep 22, 2021
@christian-bromann christian-bromann requested a review from a team September 22, 2021 09:20
@christian-bromann christian-bromann merged commit 21538c3 into main Sep 22, 2021
@christian-bromann christian-bromann deleted the cb-bump-expect-webdriverio branch September 22, 2021 12:27
@christian-bromann christian-bromann changed the title Bump expect-webdriverio to improve async jasmine execution Allow to use expect in async mode in Jasmine Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 PRs that contain changes internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant