Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only upload log files with the same cid #7461

Merged
merged 5 commits into from
Sep 22, 2021
Merged

only upload log files with the same cid #7461

merged 5 commits into from
Sep 22, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #7456

Every worker currently uploads all log files which is much more than needed. Actually we only need to upload the log files created by the worker.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Sep 22, 2021
@christian-bromann christian-bromann requested a review from a team September 22, 2021 11:58
@christian-bromann christian-bromann merged commit 3082268 into main Sep 22, 2021
@christian-bromann christian-bromann deleted the cb-upload-logs-fix branch September 22, 2021 13:02
wswebcreation
wswebcreation approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me

@wswebcreation
Copy link
Member

lol, was already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unrelated logs in the output dir are uploaded when running tests in parallel with Sauce Labs
2 participants
@christian-bromann @wswebcreation