Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors in releaseActions click command #7508

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

If a click command with parameters causing an alert to open the command fails as releaseActions fails due to a "modal open" error. We can safely ignore these errors.

fixes #6423

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Oct 4, 2021
@christian-bromann christian-bromann requested a review from a team October 4, 2021 10:53
@christian-bromann christian-bromann merged commit fd4424a into main Oct 4, 2021
@christian-bromann christian-bromann deleted the cb-ignore-releaseActions-error branch November 2, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 PRs that contain bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore unexpected alert open for click commands with coordinates
1 participant