-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7439 Propagating rule keyboard to wdio-spec-reporter #7554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising the PR!
Two things:
- can you rebase on top of current
main
branch, we had a bug small but in there that is no fixed - can you add some unit tests for your changes, e.g. for
getRule
, changes inpackages/wdio-spec-reporter/src/index.ts
and inonTestCaseStarted
Let me know if you have any question regarding that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks a lot 👍
I will go ahead and merge and will deal with the flaky e2e test in |
Proposed changes
Propagating Rule keyboard to spec reporter. This is intended to fix #7439
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers