Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7439 Propagating rule keyboard to wdio-spec-reporter #7554

Merged
merged 10 commits into from
Oct 21, 2021
Merged

#7439 Propagating rule keyboard to wdio-spec-reporter #7554

merged 10 commits into from
Oct 21, 2021

Conversation

lthurr
Copy link
Contributor

@lthurr lthurr commented Oct 14, 2021

Proposed changes

Propagating Rule keyboard to spec reporter. This is intended to fix #7439

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR!

Two things:

  • can you rebase on top of current main branch, we had a bug small but in there that is no fixed
  • can you add some unit tests for your changes, e.g. for getRule, changes in packages/wdio-spec-reporter/src/index.ts and in onTestCaseStarted

Let me know if you have any question regarding that.

@lthurr lthurr marked this pull request as draft October 15, 2021 21:21
jest.config.js Show resolved Hide resolved
@lthurr lthurr marked this pull request as ready for review October 20, 2021 19:52
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

packages/wdio-cucumber-framework/tests/utils.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot 👍

@christian-bromann
Copy link
Member

I will go ahead and merge and will deal with the flaky e2e test in main.

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 21, 2021
@christian-bromann christian-bromann merged commit 05908b6 into webdriverio:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule keyword is not propagated to reports when using cucumber framework
2 participants