Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically export expect-webdriverio types #7604

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

christian-bromann
Copy link
Member

Proposed changes

fixes #7506

This patch will automatically import the right types from expect-webdriverio based on chosen framework.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Oct 26, 2021
@christian-bromann christian-bromann requested a review from a team October 26, 2021 09:01
christian-bromann added a commit to webdriverio/expect-webdriverio that referenced this pull request Oct 26, 2021
@christian-bromann christian-bromann merged commit ceb72ca into main Oct 26, 2021
@christian-bromann christian-bromann deleted the expose-expect-types branch October 26, 2021 10:34
christian-bromann added a commit to webdriverio/expect-webdriverio that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-dom creates conflicts with WebdriverIO type system
1 participant