Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the job name before a suite is run #7672

Merged
merged 8 commits into from
Nov 15, 2021

Conversation

gabriel-kohen-by
Copy link
Contributor

Proposed changes

Per #7609 we need to account for suite before logic will be long running or failing and we want to give intication early on running the suite's tests of what is running.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this!

Let's add one or multiple test cases here and ensure that the if statement is only executed if situation is as expected.

@gabriel-kohen-by
Copy link
Contributor Author

@christian-bromann, thanks for the feedback. I've tweaked and added some assertions to account for the new logic. Let me know if there is anything I need to change.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks a lot!

packages/wdio-sauce-service/tests/service.test.ts Outdated Show resolved Hide resolved
@gabriel-kohen-by
Copy link
Contributor Author

@christian-bromann , not sure why the e2e failed on the Mac. Can't think the changes are related to this failure. Is the e2e flaky in nature?

@christian-bromann
Copy link
Member

christian-bromann commented Nov 15, 2021

@gabriel-kohen-by yeah, the windows e2e tests aren't that stable atm. Will go ahead and merge. Again, thanks a lot!

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 15, 2021
@christian-bromann christian-bromann merged commit a1d33f7 into webdriverio:main Nov 15, 2021
@gabriel-kohen-by
Copy link
Contributor Author

Thanks for merging @christian-bromann. How does the release process works as far as making it to GA?

@christian-bromann
Copy link
Member

I just need to kick off a GitHub action to release a new version. Will do so now.

@wswebcreation
Copy link
Member

This breaks setting the job name in Jasmine, because the suiteTitle is Jasmine__TopLevel__Suite and the fullName is null, so no alternative. Will fix this in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants