-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the job name before a suite is run #7672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a stab at this!
Let's add one or multiple test cases here and ensure that the if statement is only executed if situation is as expected.
Modify tests to reflect the new logic. See also: webdriverio#7609
…e for SauceLabs service. See also: webdriverio#7609
@christian-bromann, thanks for the feedback. I've tweaked and added some assertions to account for the new logic. Let me know if there is anything I need to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks a lot!
@christian-bromann , not sure why the e2e failed on the Mac. Can't think the changes are related to this failure. Is the e2e flaky in nature? |
@gabriel-kohen-by yeah, the windows e2e tests aren't that stable atm. Will go ahead and merge. Again, thanks a lot! |
Thanks for merging @christian-bromann. How does the release process works as far as making it to GA? |
I just need to kick off a GitHub action to release a new version. Will do so now. |
This breaks setting the job name in Jasmine, because the |
Proposed changes
Per #7609 we need to account for suite
before
logic will be long running or failing and we want to give intication early on running the suite's tests of what is running.Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers