Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use buffer instead of atob/btoa #7711

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Use buffer instead of atob/btoa #7711

merged 4 commits into from
Nov 18, 2021

Conversation

Nio-o
Copy link
Contributor

@Nio-o Nio-o commented Nov 18, 2021 •
edited

Use buffer instead of atob/btoa to support utf8

Details described in issue #7710

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

CLA Not Signed

@Nio-o Nio-o mentioned this pull request Nov 18, 2021
Closed
3 tasks
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 18, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@Nio-o
Copy link
Contributor Author

Nio-o commented Nov 18, 2021

Test / e2e-mac failed. Is it problem with pull request or not?

christian-bromann
christian-bromann approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test / e2e-mac failed. Is it problem with pull request or not?

No, these are usually flaky, I will continue and merge

Thanks a lot! 👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Nov 18, 2021
@christian-bromann christian-bromann merged commit 5d2de46 into webdriverio:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nio-o @christian-bromann