Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): calling sendAlertText clears local driver state #7749

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

jan-molak
Copy link
Contributor

Proposed changes

Upon calling accept(text), Puppeteer dismissed the dialog box, so the local state of the driver needs to be updated to reflect that.

This fix related to #7744

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann

Upon calling accept(text), Puppeteer dismissed the dialog box.
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up 👍

@christian-bromann christian-bromann merged commit 2d53403 into webdriverio:main Nov 24, 2021
@jan-molak
Copy link
Contributor Author

Thanks for merging 👍🏻 @christian-bromann - when do you think you could release that fix to devtools?

@christian-bromann
Copy link
Member

It seems that the current build is broken (probably because of a Chrome update), once that is fixed and build is green, we can release.

@jan-molak
Copy link
Contributor Author

No worries, give me a shout if you'd like any help with that!

@christian-bromann
Copy link
Member

Feel free to look into it, otherwise I will try tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants