Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wdio-browserstack-service logging for http status codes V7 #9538

Merged

Conversation

amaanbs
Copy link
Contributor

@amaanbs amaanbs commented Jan 4, 2023

Proposed changes

We want to update logging in cases of authorization or access errors users face. The error messages in such cases would be simply logged based on http response status code & the messages are being sent from a Browserstack server.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

@amaanbs it seems that this PR drops below the code coverage threshold, feel free to adjust it in vitest.conf.ts to get the test passing.

@christian-bromann
Copy link
Member

@amaanbs can you update the coverage treshold or increase test coverage to make the test pass?

@amaanbs
Copy link
Contributor Author

amaanbs commented Jan 18, 2023

We've simply made changes to logging statements & no additional methods have been added so updating the coverage threshold should be the way right? If yes, do let me know where to make the required changes for the same & what the new threshold should be.

@christian-bromann
Copy link
Member

As you can see in the pipeline:

Jest: "global" coverage threshold for branches (89%) not met: 88.98%

Please adjust the coverage in jest.conf.js

@christian-bromann christian-bromann merged commit 9198c2e into webdriverio:v7 Jan 20, 2023
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants