Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Visual testing #13

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Upgrade Visual testing #13

merged 3 commits into from
Apr 4, 2024

Conversation

wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented Apr 3, 2024 •
edited
Loading

This PR:

  • will remove applitools as the Visual Solution
  • will add @wdio/visual-service as the default
  • adds assignments for:
    • Desktop Web
    • Storybook
    • Nativ Mobile app

@wswebcreation wswebcreation changed the title Initial commit for the visual testing Upgrade Visual testing Apr 3, 2024
christian-bromann
christian-bromann reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

chapter_11.md Outdated Show resolved Hide resolved
chapter_11.md Show resolved Hide resolved
chapter_11.md Outdated Show resolved Hide resolved
@wswebcreation
chore: finish PR
061afd7 
- Add mobile support
- reviewed text
@wswebcreation wswebcreation marked this pull request as ready for review April 4, 2024 06:45
christian-bromann
christian-bromann approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 510975d into main Apr 4, 2024
4 of 6 checks passed
@christian-bromann christian-bromann deleted the ws/update-visual-testing branch April 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wswebcreation @christian-bromann