Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update docs #14

Merged
merged 6 commits into from
Apr 8, 2024
Merged

chore: update docs #14

merged 6 commits into from
Apr 8, 2024

Conversation

wswebcreation
Copy link
Member

@wswebcreation wswebcreation commented Apr 8, 2024 •
edited
Loading

  • update chapter 3
  • update chapter 4

@wswebcreation
Copy link
Member Author

wswebcreation commented Apr 8, 2024 •
edited
Loading

@christian-bromann

I've removed the chromedriver service, but should we also have an "extra" assignment for the onComplete hook (this is chapter 5 😅 ) Should we alter the structure? The chapter now ends very abruptly

@wswebcreation wswebcreation marked this pull request as ready for review April 8, 2024 16:15
christian-bromann
christian-bromann reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, wdyt?

chapter_03.md Outdated Show resolved Hide resolved
chapter_03.md Outdated Show resolved Hide resolved
chapter_03.md Outdated Show resolved Hide resolved
chapter_03.md Outdated Show resolved Hide resolved
wswebcreation and others added 4 commits April 8, 2024 19:45
@wswebcreation @christian-bromann
Update chapter_03.md
5db5227 
Co-authored-by: Christian Bromann <git@bromann.dev>
@wswebcreation @christian-bromann
Update chapter_03.md
1d4d4cf 
Co-authored-by: Christian Bromann <git@bromann.dev>
@wswebcreation @christian-bromann
Update chapter_03.md
ef1df57 
Co-authored-by: Christian Bromann <git@bromann.dev>
@wswebcreation
chore: update adding the specs
daccb6f
christian-bromann
christian-bromann approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@christian-bromann christian-bromann merged commit 1978cf7 into main Apr 8, 2024
6 checks passed
@christian-bromann christian-bromann deleted the ws/fix-some-stuff branch April 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wswebcreation @christian-bromann