-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android 12 #3
Comments
I did see your crash reports today. The issue is not due to Android 12. From my guesses you are running either an old version of PiFire Server (prior to 1.2.0) or possibly the current development branch. The crash issue should be resolved in the next version of the app but if you are running a version of PiFire Server that is older than 1.2.0 or you are using the current development branch (1.2.7-dev3) then the app will not load any data as the app is not supported before 1.2.0 and some of the API's have changed in 1.2.7-dev3. Do you know what PiFire Server version you are using? ** Edit ** I have pushed a release to stop the crashing if the PiFire Server does not respond to the websocket requests. You can find that version here If you are running the PiFire Server development branch of 1.2.7-dev3 then you will need to use the pre-release version 1.4.0-dev2 of PiFire Android located here |
Yes I am running 1.2.7 dev version, I will try version 1.4.0 of the android app, sorry I assumed it was android 12, I just had it pushed to my phone a few days ago and some apps behave the same way. Thanks for the quick response. |
Confirm everything works as expected with 1.4.0 android app on server 1.2.7 dev. Thank you |
Awesome. Thanks for pointing out the issue on older versions at least I could push a version to prevent it from crashing. |
@faisalhusain007 I see you found some other bug in the dev version and had a crash. It is strange as it is not crashing on my devices or emulators. I am looking into the crash to see why it may have happened but is there anything you could tell me about it? Is it still happening when launching the app? |
No its because I have added some code for the DC fan on my server, the issue is that the settings.json has 2 extra outputs dcfan and psu, but when i pull the update from git my common and grillplat get overwritten but the settings.json still have reference to the output pins. This causes both the server side and android app to crash. Sorry about that will fix and test. |
No worries at all. I am not sure this crash was due to settings.json as I believe the app should just ignore any extra settings that may be in the json. If it was malformed json it could cause an issue but even then the app should catch the exception and just not update the settings locally. Anyway thanks for responding back! |
I believe the issue might be that control exits with an error but only after trying to initialize either monitor or startup, when it runs through the function GetOutpStatus in grillplat |
The crashing issue should not have been related to your setup. I found an issue in the app and corrected it in version 1.4.0-dev3 or later. That should solve the random crash. |
Great thanks for the update. I was wondering if you have a compiled version of 1.4.0-dev3 with the android OneSignal, would like to test it. |
Ya there is v1.4.0-dev3 and I just uploaded v1.4.0-dev4 earlier today. You can find them on the releases page here |
Thanks a lot will test it out soon. |
The app seems to keep crashing in Android 12. Sorry dont have anymore details.
The text was updated successfully, but these errors were encountered: