Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coveralls badge branch in URL query param #69

Open
owayss opened this issue Apr 28, 2021 · 0 comments
Open

coveralls badge branch in URL query param #69

owayss opened this issue Apr 28, 2021 · 0 comments

Comments

@owayss
Copy link

owayss commented Apr 28, 2021

The coveralls badge has the branch URL query parameters set to the fixed string branch, instead of the user provided value for the branch attribute.

This is fixed in #68.

Current behavior:

For a badge configured like so:

$ tail -n1 Cargo.toml
coveralls = { repository = "owayss/huffman-encoding",  branch = "main" }

It configures the badge as:

$ cargo readme |grep coveralls
[![Coverage Status](https://coveralls.io/repos/github/owayss/huffman-encoding/badge.svg?branch=branch)](https://coveralls.io/github/owayss/huffman-encoding?branch=main)

Expected behavior

The branch URL query parameter should have the value provided for the branch attribute, that is, branch=main instead of branch=branch:

[![Coverage Status](https://coveralls.io/repos/github/owayss/huffman-encoding/badge.svg?branch=main)](https://coveralls.io/github/owayss/huffman-encoding?branch=main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant