Add support for writing pitch bend messages #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thank you. |
webern
reviewed
May 31, 2023
src/core/message.rs
Outdated
| @@ -807,4 +834,4 @@ impl WriteBytes for ControlChangeValue { | |||
| write_u8!(w, self.value.get())?; | |||
| Ok(()) | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Can you run cargo fmt and force push the fix to this commit?
There was a problem hiding this comment.
@webern - I think I did this but hopefully got the commit/push right. Let me know if not.
There was a problem hiding this comment.
The issue was changes to the clippy linter. I have pushed a fix as a separate commit to this PR.
robrennie
force-pushed
the
pitchbend_write
branch
from
790ce93
to
7ff3019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#10
Description of Changes
Added simple write of PitchBend message.
Testing
Needed to have this to write atonal MIDI messages for a project I'm working on. I didn't have time time add it to the sample test, so use it if you like it. Works like a charm for me.
Disclaimer
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.