api: support non-traditional key signatures #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webern
commented
Apr 1, 2020
webern
force-pushed
the
feature/non-traditional-key
branch
from
ecf149b
to
615b160
Compare
p-groarke
reviewed
Apr 4, 2020
| const auto intAlter = static_cast<int>( xmlAlter ); | ||
| const auto micro = xmlAlter - static_cast<mx::core::DecimalType> ( intAlter ); | ||
| const auto microDistance = std::abs( micro ); | ||
| if( microDistance >= 0.000000000001 ) |
There was a problem hiding this comment.
If you want, you can use std::numeric_limits<double>::epsilon() which gives the smallest increment of the numeric type T you provide it with.
There was a problem hiding this comment.
I'll play around with that.
p-groarke
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
Replaces #77