Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to C++17 #93

Merged
merged 10 commits into from
May 16, 2020
Merged

bump to C++17 #93

merged 10 commits into from
May 16, 2020

Conversation

webern
Copy link
Owner

@webern webern commented May 11, 2020 •
edited
Loading

Bumping to C++17 as std::optional in particular could make some things easier to express in mx::api instead of continuing the pattern of having a bool isSpecified for future optional things.

@webern
Copy link
Owner Author

webern commented May 11, 2020

I need to figure out why GCC 10 is angry.

@webern
Copy link
Owner Author

webern commented May 14, 2020 •
edited
Loading

Looks like this may be the GCC 10 issue with C++20:
catchorg/Catch2#1929

I had opened this issue:
catchorg/Catch2#1930

@webern webern changed the title bump c++ version to 20 bump c++ version to 17 May 16, 2020
@webern webern changed the title bump c++ version to 17 bump to C++17 May 16, 2020
@webern webern merged commit c648491 into master May 16, 2020
@webern webern deleted the cpp20 branch June 20, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@webern