Improve unit tests

webeweb · May 29, 2020 · 141b0bc · 141b0bc
1 parent 52f5830
commit 141b0bc
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/tests/Serializer/RequestSerializerTest.php b/tests/Serializer/RequestSerializerTest.php
@@ -37,12 +37,10 @@ public function testSerializeBreachedAccountRequest() {
         $arg->setIncludeUnverified(true);
         $arg->setTruncateResponse(true);
 
-        $res = [
-            "domain"            => "domain",
-            "includeUnverified" => "true",
-            "truncateResponse"  => "true",
-        ];
-        $this->assertEquals($res, RequestSerializer::serializeBreachedAccountRequest($arg));
+        $res = RequestSerializer::serializeBreachedAccountRequest($arg);
+        $this->assertEquals("domain", $res["domain"]);
+        $this->assertEquals("true", $res["includeUnverified"]);
+        $this->assertEquals("true", $res["truncateResponse"]);
     }
 
     /**
@@ -55,8 +53,8 @@ public function testSerializeBreachedAccountRequestWithoutArguments() {
         // Set a Breached account request mock.
         $arg = new BreachedAccountRequest();
 
-        $res = [];
-        $this->assertEquals($res, RequestSerializer::serializeBreachedAccountRequest($arg));
+        $res = RequestSerializer::serializeBreachedAccountRequest($arg);
+        $this->assertEquals([], $res);
     }
 
     /**
@@ -70,8 +68,8 @@ public function testSerializeBreachesRequest() {
         $arg = new BreachesRequest();
         $arg->setDomain("domain");
 
-        $res = ["domain" => "domain"];
-        $this->assertEquals($res, RequestSerializer::serializeBreachesRequest($arg));
+        $res = RequestSerializer::serializeBreachesRequest($arg);
+        $this->assertEquals("domain", $res["domain"]);
     }
 
     /**
@@ -84,7 +82,7 @@ public function testSerializeBreachesRequestWithoutArguments() {
         // Set a Breach request mock.
         $arg = new BreachesRequest();
 
-        $res = [];
-        $this->assertEquals($res, RequestSerializer::serializeBreachesRequest($arg));
+        $res = RequestSerializer::serializeBreachesRequest($arg);
+        $this->assertEquals([], $res);
     }
 }