revert: fix(tooling): do not run dist-tag silently

webex · May 21, 2017 · d77c07e · d77c07e
1 parent 441570d
commit d77c07e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/Jenkinsfile b/Jenkinsfile
@@ -372,9 +372,7 @@ ansiColor('xterm') {
                 env.NODE_ENV = ''
                 image.inside(DOCKER_RUN_OPTS) {
                   echo 'getting latest published versions from npm; this might take a moment'
-                  // NOTE: get-next-version MUST NOT be --silenced or the build
-                  // will fail if includes new packages
-                  version = sh script: 'npm run get-next-version', returnStdout: true
+                  version = sh script: 'npm run --silent get-next-version', returnStdout: true
                   version = version.trim()
                   echo "next version is ${version}"
                   sh 'npm run build'

diff --git a/tooling/lib/npm.js b/tooling/lib/npm.js
@@ -43,12 +43,7 @@ exports.getDistTag = async function getDistTag(packageName) {
       return tags.latest;
     }
     catch (err) {
-      // ignore 404s; they're normal for new packages
-      if (!/npm ERR! 404 Registry returned 404 for GET on/.test(err)) {
-        debug(`error occurred for ${packageName}`, err);
-        throw err;
-      }
-      debug(`received 404 for ${packageName}, skipping`);
+      debug(`Something went wrong, but we had to use --silent, so it's hard to tell what`, err);
     }
   }
   return undefined;