feat(widget-chat): encode and send markdown inputs #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds on #324 |
bzang
approved these changes
Nov 14, 2016
There was a problem hiding this comment.
LGTM.
The only thought I had was thinking about if there's any way we can pull the markdown feature out into it's own component so that it isn't as deeply connected with our base messages. That would make it easier later on if a developer doesn't want to enable markdown, they could just not include the component instead of having to use flag checks. Not necessary now, but just something to think about.
| }; | ||
|
|
||
| return messageObject; | ||
| } |
There was a problem hiding this comment.
Nice!
I may pull this out into it's own separate helper file when I move things to use the activity structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.