Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update publish command and add notice to raise PR against next branch #3013

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

rajeshtezu
Copy link
Contributor

@rajeshtezu rajeshtezu commented Aug 21, 2023

COMPLETES #<SPARK-449056>

This pull request addresses

  • Updates the publish command in each package.json file under packages
  • Add notice to announce master branch will be frozen and to raise all the PRs against next branch

by making the following changes

Screenshot 2023-08-23 at 8 32 06 PM

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@rajeshtezu rajeshtezu requested a review from a team as a code owner August 21, 2023 10:26
@rarajes2 rarajes2 added the validated If the pull request is validated for automation. label Aug 21, 2023
@rarajes2 rarajes2 marked this pull request as draft August 22, 2023 13:43
@rarajes2 rarajes2 changed the title docs: add notice to raise PR against next branch chore: add notice to raise PR against next branch Aug 23, 2023
@rarajes2 rarajes2 changed the title chore: add notice to raise PR against next branch fix: update publish command and add notice to raise PR against next branch Aug 23, 2023
@rarajes2 rarajes2 marked this pull request as ready for review August 23, 2023 07:58
@rarajes2 rarajes2 requested a review from a team as a code owner August 23, 2023 07:58
Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment regarding the text

CONTRIBUTING.md Outdated Show resolved Hide resolved
@rajeshtezu rajeshtezu force-pushed the contib-notice branch 2 times, most recently from d590ba2 to 6f31116 Compare August 24, 2023 05:50
Copy link
Collaborator

@InteractiveTimmy InteractiveTimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this to publish within a workspace environment, the command on each package must used yarn:

yarn npm publish

@rarajes2
Copy link
Contributor

In order for this to publish within a workspace environment, the command on each package must used yarn:

yarn npm publish

Done

@rarajes2 rarajes2 merged commit 124e18f into webex:next Aug 29, 2023
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants