feat(calling): port calling code into next #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com> Co-authored-by: Priya Kesari <pkesari@cisco.com>
Co-authored-by: Priya Kesari <pkesari@cisco.com>
Co-authored-by: Dipanshu Sharma <dipashar@cisco.com>
11 tasks
Kesari3008
requested changes
Sep 4, 2023
| @@ -37,17 +38,34 @@ | |||
| "envify" | |||
| ] | |||
| }, | |||
| "scripts": { | |||
There was a problem hiding this comment.
Why did we need these changes here ?
There was a problem hiding this comment.
@Kesari3008 we weren't building the webex package so far in the next branch. We were only building the remaining plugins and testing deployments to npm. As part of this change, we will be building the webex package as well. This was needed in order to get the calling bundle built as well.
There was a problem hiding this comment.
If we don't have these scripts, we observe the following error when doing yarn run build at webex-js-sdk level. Without this, the *.min.js files do not get created.
ERROR in ./packages/webex/src/calling.js 11:0-47
Module not found: Error: Can't resolve '@webex/calling' in '/Users/sreenara/Stuff/Repos/webex-js-sdk/packages/webex/src'
resolve '@webex/calling' in '/Users/sreenara/Stuff/Repos/webex-js-sdk/packages/webex/src'
Parsed request is a module
Kesari3008
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES # NA
This pull request
Brings in the calling code into the next branch for the upcoming release of the Public Calling SDK.
by making the following changes
packages/callingfrompackges/calling/callingbabel.config.jsunderpackages/webexand update package.json to start building thewebexpackage.webpack.config.jsto include build of calling.min.jstooling/babel-plugin-inject-package-version.jsby putting in a dummy string for version for now. This is a TODO item.Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.