Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(call): merge calling-sdk commits after 1.68.0 #3054

Merged

Conversation

Kesari3008
Copy link
Contributor

@Kesari3008 Kesari3008 commented Sep 5, 2023

COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-438063

This pull request addresses

Merging commits from calling-sdk repo to js-sdk after the 1.68.0 version.

by making the following changes

fix(call): handle-hyphen-in-dialed-number(250)
fix(call): handle roap ok receipt before completion of handleOutgoingRoapAnswer(249)
feat(callsettings): ucm implementation(247)
fix(callsettings): eslint fix(248)
feat(callsettings): new design for call settings WxC(246)
fix(media-core): fmtp fix internal media core update(245)
fix(voicemail): voicemail-summary-types-updated(#244)
fix(utils): bug in callerId resolution(242)
fix(readme): temporary commit to trigger a manual publish(243)
feat(voicemail): Spark 432219 optimise voicemail logic to use summary api(240)
fix(metrics): transfer metrics(241)
fix(ucmconnector): added ucmc test case for voicemail list read unread delete(234)
fix(voicemail): transcript status is not being utilized(239)
feat(voicemail): Implement metrics in the voicemail(238)
fix(call): hold event not processed if media negotiation is completed before connect event in delayed media case(237)

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@Kesari3008 Kesari3008 added the validated If the pull request is validated for automation. label Sep 5, 2023
@Kesari3008 Kesari3008 marked this pull request as ready for review September 6, 2023 11:26
@Kesari3008 Kesari3008 requested a review from a team as a code owner September 6, 2023 11:26
Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a list of the commits in the PR description as well so we have reference of the commits. Commit names would also be good.

Copy link
Contributor

@sreenara sreenara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one suggestion. Please remove the links to the PRs in the description as these are internal and shouldn't be exposed in a public domain. Just leave the commit messages.

@Kesari3008 Kesari3008 force-pushed the SPARK-438063-Merge-commits-from-web-calling-sdk branch from 2cbef90 to 7e082db Compare September 12, 2023 04:54
@Kesari3008 Kesari3008 force-pushed the SPARK-438063-Merge-commits-from-web-calling-sdk branch from 7e082db to 108339a Compare September 12, 2023 16:23
@Kesari3008 Kesari3008 merged commit c26dcab into webex:next Sep 12, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants