Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add umd build for deploy step, provide local build command #3057

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

sreenara
Copy link
Contributor

@sreenara sreenara commented Sep 5, 2023

COMPLETES #NA

This pull request addresses

the issue of not building the bundles for deployment.

by making the following changes

  1. Fixed the command to build UMD in the deploy.yml
  2. Added a script in the root package.json to make it easier for developers to build locally and test samples
  3. Changed the commands in the CONTRIBUTING.md accordingly.
  4. Removed unnecessary webex dependency in packages/calling/package.json

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

Tested building the code - UMD folder created successfully
No errors observed for commands running in deploy.yml
Was able to build and host samples page locally.

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@sreenara sreenara requested a review from a team as a code owner September 5, 2023 18:23
@sreenara sreenara added the validated If the pull request is validated for automation. label Sep 5, 2023
@@ -44,7 +44,6 @@
"jest-html-reporters": "3.0.11",
"platform": "1.3.6",
"uuid": "8.3.2",
"webex": "1.154.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we remove this intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @rarajes2 . We removed this because we don't use webex as a dependency this way. We actually never used it even while this was in the internal repo. This should have been removed long ago.

@sreenara sreenara merged commit d3a9487 into webex:next Sep 6, 2023
17 of 21 checks passed
@sreenara sreenara deleted the fix-umd branch September 6, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants