docs(calling): improve samples UI. add back getDevice #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/samples/calling/style.css
Outdated
| } | ||
|
|
||
| .docs { | ||
| overflow: auto; | ||
| height: 98vh; | ||
| max-width: 1400px; |
There was a problem hiding this comment.
can we convert this px value to ``rem value here ?
replace to
max-width: 87.5rem
| select { | ||
| padding: 0 0.5rem; | ||
| height: 1.75rem; | ||
| border-radius: 4px; |
There was a problem hiding this comment.
can we use rem value here as well ?
There was a problem hiding this comment.
We should not change border radius if the root font-size changes.
| } | ||
|
|
||
| section { | ||
| background-color: #fff; | ||
| padding: 1rem; | ||
| margin-bottom: 2rem; | ||
| margin-bottom: 1.5rem; | ||
| border-radius: 8px; |
rajeshtezu
force-pushed
the
calling-sample-improvement-SPARK-458857
branch
2 times, most recently
from
6abb36e
to
b4387db
Compare
rajeshtezu
force-pushed
the
calling-sample-improvement-SPARK-458857
branch
from
b4387db
to
f409589
Compare
Kesari3008
requested changes
Sep 21, 2023
Kesari3008
reviewed
Sep 21, 2023
rajeshtezu
force-pushed
the
calling-sample-improvement-SPARK-458857
branch
from
f409589
to
4a21c48
Compare
Kesari3008
requested changes
Sep 22, 2023
rajeshtezu
force-pushed
the
calling-sample-improvement-SPARK-458857
branch
2 times, most recently
from
cd9c3d9
to
78e9ba9
Compare
karthikraji2020
approved these changes
Sep 23, 2023
Kesari3008
approved these changes
Sep 25, 2023
rajeshtezu
force-pushed
the
calling-sample-improvement-SPARK-458857
branch
from
78e9ba9
to
95dcd93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< SPARK-458857 >
This pull request addresses
by making the following changes
Before
After
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.