fix(call): update method to send digit in call and readme #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreenara
commented
Sep 19, 2023
| @@ -46,7 +46,7 @@ | |||
| "test:integration": "webex-legacy-tools test --integration --runner mocha", | |||
| "test:style": "eslint ./src/**/*.*", | |||
| "test:unit": "webex-legacy-tools test --unit --runner jest", | |||
| "deploy:npm": "yarn npm publish" | |||
| "deploy:npm": "echo yarn npm publish" | |||
There was a problem hiding this comment.
Adding echo here as we are not publishing webex object on next branch to npm yet. Will do this in a future PR. This PR is to test that the pipeline publishes the calling package correctly.
sreenara
commented
Sep 19, 2023
| "test:style": "eslint ./src/**/*.*", | ||
| "test:unit": "webex-legacy-tools test --unit --runner jest", | ||
| "deploy:npm": "yarn npm publish" | ||
| "test:style:todo": "eslint ./src/**/*.*", |
There was a problem hiding this comment.
Adding todos here as these need to be fixed as part of a different PR before release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES # NA. Adhoc Change.
This pull request addresses
by making the following changes
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.