test(calling): voicemail module test cases added

[meta-dipanshu-sharma]

COMPLETES #< SPARK-422971 >

This pull request addresses

Code coverage for voicemail module files were less. Need to write UT to cover the uncovered code.

by making the following changes

Added UTs for following files:

1. BroadworksBackendConnector.test.ts
2. UcmBackendConnector.test.ts
3. Voicemail.test.ts

Some code refactor in below files:

1. BroadworksBackendConnector.ts
2. UcmBackendConnector.ts
3. Utils.ts

CODE COVERAGE REPORT:
PREVIOUSLY

CURRENT:

Change Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Tooling change
• Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

• I have read and followed contributing guidelines

• I discussed changes with code owners prior to submitting this pull request

• I have not skipped any automated checks

• All existing and new tests passed

• I have updated the documentation accordingly

---

Make sure to have followed the contributing guidelines before submitting.

[karthikraji2020]

Left few comments. please check.

[BhargavSatya]

as number is known to be problematic and we are changing it whenever we encounter it during new changes. Applicable across all files in the module. Please add this change.

Suggested change

	statusCode: statusCode as number,
	statusCode: Number(statusCode),

[meta-dipanshu-sharma]

Done

[BhargavSatya]

Can we not set '' as default statusCode. Put 422 or equivalent code. Applicable across the changes.

Suggested change

	statusCode: err instanceof Error ? Number(err.message) : '',
	statusCode: err instanceof Error ? Number(err.message) : 422,

[meta-dipanshu-sharma]

We're setting default statusCode as 422 in serviceErrorCodeHandler in the default switch statement when it doesn't matches with any of the status code. If we want to set it default here then we have to update it at multiple places wherever ' ' is passsed. Do you still suggest changing this at multiple places or current implementation is acceptable?

[BhargavSatya]

Thats fine . Ignore this if it was like this

[BhargavSatya]

Minor comments.
Can we try to increase branch coverage to minimum of 85% as well?

[Shreyas281299]

Minor comments.

[meta-dipanshu-sharma]

Minor comments. Can we try to increase branch coverage to minimum of 85% as well?

@BhargavSatya I have made BroadworksBackendConnector file's branch coverage to >85%. For UcmBackendConnector file, we were not able to cover some part of code and those branches are part of those lines only so could not cover them as well.