feat(callingsdk): initial changes to add bnr #3120
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| Logger, | ||
| NoiseReductionEffect, |
There was a problem hiding this comment.
Do we have to export NoiseReductionEffect what is its use exporting?
There was a problem hiding this comment.
If we don't export, it will not be available to be used in samples page or by developer also
There was a problem hiding this comment.
I thought developers will use this method to create the NoiseReductionEffect: static createNoiseReductionEffect(authToken) . What is this about?
There was a problem hiding this comment.
Yeah, that's what developers are using. But did you see what's happening inside that static function? We are using NoiseReductionEffect inside that function. and to get access of the same, it needs to be re-exported from index.ts
There was a problem hiding this comment.
I did see. Just noticed the it was a js file. Lack of any return type in the signature and description confused me. Nevermind.
Co-authored-by: Priya Kesari <pkesari@cisco.com>
COMPLETES #SPARK-433414
This pull request addresses
Adding changes to use the BNR feature in CallingSDK for WebRTC Calling.
by making the following changes
Added static function to create and return NoiseReductionEffect object in calling.js
Added the effect to the localMicrophoneStream being used for calls in app.js and enabled it.
Listening for 'output_track_change' event to update the tracks once BNR is enabled/disabled.
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.