fix(media-helpers): vbg effect on local stream #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkesavan13
approved these changes
Apr 23, 2024
sreenara
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM.
@marcin-bazyl FYI the web client is manually resolving to 2.15.6 of web-media-effects so I don't believe merging this should cause any issues. We need this latest fix on the SDK. Please let us know if there's anything that we need to be cognizant of.
marcin-bazyl
approved these changes
Apr 23, 2024
Shreyas281299
pushed a commit
to Shreyas281299/webex-js-sdk
that referenced
this pull request
Apr 26, 2024
sreenara
pushed a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< SPARK-502882 >
This pull request addresses
When a VBG image/video is enabled and the user toggles off the video, only the Camera source gets shut and the effect tends to stay in the Local Stream.
by making the following changes
Fixes the issue mentioned
VBG.fix.mov
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.