feat(plugin-meetings): use [peripheralName]Info instead of peripherals in MQE #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeBody16
force-pushed
the
WEBEX-381729
branch
3 times, most recently
from
2d90937
to
177d598
Compare
SomeBody16
force-pushed
the
WEBEX-381729
branch
from
177d598
to
9f50c65
Compare
marcin-bazyl
approved these changes
Apr 29, 2024
SomeBody16
force-pushed
the
WEBEX-381729
branch
from
9f50c65
to
6642085
Compare
SomeBody16
force-pushed
the
WEBEX-381729
branch
from
6642085
to
bf26f9f
Compare
SomeBody16
changed the title
…eripherals in MQE
Shreyas281299
pushed a commit
to Shreyas281299/webex-js-sdk
that referenced
this pull request
May 10, 2024
…s in MQE (webex#3565) Co-authored-by: Filip Nowakowski <fnowakow@cisco.com>
sreenara
pushed a commit
that referenced
this pull request
May 10, 2024
…s in MQE (#3565) Co-authored-by: Filip Nowakowski <fnowakow@cisco.com>
brycetham
pushed a commit
to brycetham/webex-js-sdk
that referenced
this pull request
May 30, 2024
…ripherals in MQE (webex#3565)" This reverts commit bd29ca8.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES WEBEX-381729
This pull request addresses
MQA team has announced that they are removing the peripherals property in MQE and will only use cameraInfo/microphoneInfo/speakerInfo instead. Currently, on the web client, we are only populating the peripherals property and are not populating cameraInfo/microphoneInfo/speakerInfo. This PR addresses this issue
See pinned message in the Ask MQA space for more details.
webexteams://im?space=e291a140-f2a2-11ea-a094-5519499aaa4d&message=e1895b50-0133-11ef-9b2a-b19ef59b66fb
by making the following changes
Changes filling peripherals field in MQE to cameraInfo/ microphoneInfo/ speakerInfo
Change Type
The following scenarios where tested
samples:servecorrectly emitted changed statsI certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.