fix: remove the logic of setting b=TIAS lines in the internal media core #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antsukanova
changed the title
marcin-bazyl
approved these changes
Apr 26, 2024
Neeraj-swarnkar
pushed a commit
that referenced
this pull request
Apr 29, 2024
…ore (#3574) Co-authored-by: Anna Tsukanova <antsukan@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES WEBEX-326842
This pull request addresses
WCME munged the SDP answer and created copies of m-sections before passing the SDP to the browser via setRemoteDescription(). As a result, if there was a global b=TIAS line and b=TIAS lines at some media sections, the totals don't add up correctly in the munged SDP answer. This causes issues with audio in Chrome.
by making the following changes
This request is about removing the logic of setting b=TIAS lines in the WCME and removing some logic fixes in the internal media core.
Change Type
The following scenarios where tested
tested manually with the web app and js-sdk app
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly