Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(media-helpers): change type for local camera stream events #3584

Merged
merged 1 commit into from
May 2, 2024

Conversation

mkesavan13
Copy link
Contributor

@mkesavan13 mkesavan13 commented May 2, 2024

COMPLETES AdHoc

This pull request addresses

LocalCameraStreamEvents uses LocalMicrophoneStreamEventNames instead of LocalCameraStreamEventNames

by making the following changes

LocalCameraStreamEventNames is used for LocalCameraStreamEvents instead of LocalMicrophoneStreamEventNames

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@mkesavan13 mkesavan13 requested a review from a team as a code owner May 2, 2024 10:21
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3584.d3m3l2kee0btzx.amplifyapp.com

@marcin-bazyl marcin-bazyl merged commit 5bf0922 into webex:beta May 2, 2024
2 checks passed
Shreyas281299 pushed a commit to Shreyas281299/webex-js-sdk that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants