Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable Webpack minimize #107

Merged
merged 4 commits into from Nov 4, 2018
Merged

Option to disable Webpack minimize #107

merged 4 commits into from Nov 4, 2018

Conversation

balcsida
Copy link
Member

@balcsida balcsida commented Nov 1, 2018 •
edited

Closes #57

@balcsida balcsida self-assigned this Nov 1, 2018
@balcsida balcsida mentioned this pull request Nov 1, 2018
Closed
@balcsida balcsida changed the title [WIP] Option to disable Webpack minimize Option to disable Webpack minimize Nov 3, 2018
@balcsida
Copy link
Member Author

balcsida commented Nov 3, 2018

Hi @HaNdTriX,

If you have time, could you please take a look on this Pull Request?
If it is okay for you, I would like to try to release on NPM, please.

Warm regards,
@balcsida

HaNdTriX
HaNdTriX reviewed Nov 4, 2018
View reviewed changes
Copy link
Contributor

@HaNdTriX HaNdTriX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Good job looks perfect 👌

Please note that this is a breaking change. So we need to publish a major release.

@balcsida balcsida merged commit 0183506 into master Nov 4, 2018
@balcsida balcsida deleted the minification branch November 4, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaNdTriX HaNdTriX HaNdTriX left review comments

Assignees

@balcsida balcsida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balcsida @HaNdTriX