Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking-change] Version 4 #143

Merged
merged 4 commits into from Mar 2, 2022
Merged

[breaking-change] Version 4 #143

merged 4 commits into from Mar 2, 2022

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Mar 12, 2019

After getting feedback from the community I believe adding react presets to core was not a good idea.

Therefore this PR introduces some breaking changes, that opens the this toolbox for frameworks like vue, svelte, angular and typescript.

What changes?

From now on webextension-toolbox only includes relevant presets needed to create a browser extension. Actually the only preset that is included is preset-env. This is preconfigured by the binary.

It configures the right vendor and the vendorVersion.

  • vendor: chrome, firefox, edge, etc.
  • vendorVersion: if not provided webextension-toolbox uses the last 3 Versions of the current vendor.

How do I use react?

  1. npm install @babel/preset-react --save-dev
  2. Create a .babelrc file next to your package.json file and insert the following contents:
{
  "presets": [
    "@babel/preset-react"
  ]
}

Todo

  • Update docs
  • Write migration guide
  • Implement react promt in generator-web-extension
  • Release as major version
  • Evaluate if we still need the other presets
  • Create a legacy preset

@HaNdTriX HaNdTriX changed the title [WIP] Make preset a real preset [WIP] Version 4 Mar 13, 2019
@HaNdTriX HaNdTriX changed the title [WIP] Version 4 [breaking-change] Version 4 Mar 13, 2019
@bboydflo
Copy link

this would be awesome! 💯

@balcsida balcsida added this to In progress in 4.0 Sep 28, 2019
@tm1000 tm1000 mentioned this pull request Nov 29, 2021
@tm1000 tm1000 mentioned this pull request Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4.0
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants