Disable webpacks eval code #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
added a commit
that referenced
this pull request
Jun 25, 2018
Firefox webstore csp policy prohibits the use of eval or func consturctor. RELATED ISSUE: #34
HaNdTriX
added a commit
that referenced
this pull request
Jun 25, 2018
Firefox webstore csp policy prohibits the use of eval or func consturctor. RELATED ISSUE: #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using eval in chrome extensions is not recommended, since it opens the door for many security issues.
Webpack uses eval, in order to provide a
globalobject. This feature is build in a way, that usesevalunder the hood. (Souce)Since webextensions always run in a web context, we don't need this functionality.
Instead we can link
globalwithwindow. This is why this PR doesn't introduce a breaking change.