Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized strings are now being removed from manifest.json #167

Closed
rthaut opened this issue Apr 16, 2022 · 1 comment
Closed

Localized strings are now being removed from manifest.json #167

rthaut opened this issue Apr 16, 2022 · 1 comment

Comments

@rthaut
Copy link
Contributor

rthaut commented Apr 16, 2022

It seems localized strings in the manifest.json file are erroneously being removed during the "compilation" process.

A source manifest.json file containing the following contents:

{
  "manifest_version": 3,
  "name": "__MSG_extensionName__",
  "description": "__MSG_extensionDescription__",
  "version": "1.0"
}

Results in this invalid manifest.json (note the empty name and description properties):

{
  "manifest_version": 3,
  "name": "",
  "description": "",
  "version": "1.0"
}

However, the expected output is:

{
  "manifest_version": 3,
  "name": "__MSG_extensionName__",
  "description": "__MSG_extensionDescription__",
  "version": "1.0"
}

I haven't done any debugging yet, but a cursory glance leads me to believe the transformManifestValuesFromENV() method introduced in v2.0.1 is the culprit, as the was not an issue in v1.0,0 and earlier.

@tm1000
Copy link
Member

tm1000 commented Apr 19, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants