Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: support for scoping organization level machine user ssh keys #111

Closed
leitmedium opened this issue Apr 11, 2022 · 1 comment
Closed

Comments

@leitmedium
Copy link

Hey,

it is currently supported to use comments for scoping ssh keys to specific repositories which works well with deployment keys that are bound to one repository. If you follow GitHub suggestion and make use of machine users and ssh keys for organization wide access to repositories you currently cannot scope them to a pattern like git@github.com/organization/ . This would however allow to juggle with different types of ssh keys. This applies to owner based matching, too, of course.

If I understand the code right, the easiest solution might be to just allow

const parts = key.match(/\bgithub\.com[:/]([_.a-z0-9-]+\/)/i);

But I might miss a part of replacement logic here.

Best,

Caspar.

@mpdude
Copy link
Member

mpdude commented Sep 1, 2022

There are duplicate reports for this. I've created #128 to focus the discussion in one issue.

@mpdude mpdude closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants