Convert all path sep to unix in config. Fixes #121 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmeijer - Do you mind checking this out? |
| @@ -51,7 +51,7 @@ DecoratorManager.prototype.new = function(options, callback) { | |||
|
|
|||
| // Get the src, test paths | |||
| var setupConfig = R.mapObjIndexed(function(empty, type) { | |||
| return path.join(type, 'decorators', name+'Decorator'); | |||
| return `${type}/decorators/${name}Decorator`; | |||
There was a problem hiding this comment.
I've never seen this before (the '${var}'..).
Is it some built in template?
There was a problem hiding this comment.
I am using ES6 and using babel to cross compile down to es5. These are ES6 string templates - basically they are strings with interpolation. ie, 'hello ' + name + ', my name is ' + me is the same as 'hello ${name}, my name is ${me}'
There was a problem hiding this comment.
Cool, had a feeling that was the case. Thanks for the fix btw!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.