New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli should use webgme-engine as a dependency #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just a little change in the test that I suspect will cause it to break in the future
// Compare the package.json values | ||
var packageJSON = path.join(initProject, 'package.json'), | ||
toolJson = path.join(__dirname, '..', 'package.json'), | ||
toolDeps = require(toolJson).dependencies, | ||
deps = require(packageJSON).peerDependencies; | ||
|
||
assert.equal(deps.webgme, toolDeps.webgme); | ||
assert.equal(deps.webgme, toolDeps['webgme-engine']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't currently checking the major version... I think this test will fail after a patch/minor release of webgme (without an update to webgme-engine), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually no. It's not reading the installed version but rather the required version which is ^2.0.0.
…me/webgme-cli into webgme-engine-as-dependency
No description provided.