Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enqueuing all identifiers logic #12

Closed
mmenozzi opened this issue May 5, 2020 · 3 comments
Closed

Enqueuing all identifiers logic #12

mmenozzi opened this issue May 5, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mmenozzi
Copy link
Member

mmenozzi commented May 5, 2020

As stated in #5, currently the only way for an importer to enqueue identifiers is to implement the \Webgriffe\SyliusAkeneoPlugin\ImporterInterface::getIdentifiersModifiedSince() which assumes that you can get from the Akeneo API only those resources modified since a given date.

Unfortunately this is not always true. On the contrary this is true only for products and product models, all other resources cannot be fetched by "updated at" date/time.

So we need a different enqueuing logic.
Based on the fact that all these resources are "catalog structure", they should not change very often. So one solution could be to enqueue all identifiers for this resources.
Doing so will require a change in the webgriffe:akeneo:enqueue CLI command to allow users to have a different cron schedule potentially for every resource/importer (or a completely separate command).

@mmenozzi mmenozzi added enhancement New feature or request help wanted Extra attention is needed labels May 5, 2020
@mmenozzi mmenozzi self-assigned this Nov 4, 2020
@mmenozzi
Copy link
Member Author

mmenozzi commented Nov 4, 2020

@fabianaromagnoli @LucaGallinari my proposal for the webgriffe:akeneo:enqueue command is:

  • Add a new --importer="<importer>" option which if specified enqueue only items for the given importer. If not specified will enqueue items for all importers (like it does now)
  • Add a new --all option. If given it will enqueue all identifiers for the given importers (or all importers). One of --all, --since or --since-file must be specified.

Those changes should be backward compatibile.
What do you think?

@LucaGallinari
Copy link
Member

It's a good solution!

@mmenozzi
Copy link
Member Author

Done in #18. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants