Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API client replacement #125

Merged
merged 14 commits into from Apr 11, 2022
Merged

API client replacement #125

merged 14 commits into from Apr 11, 2022

Conversation

lruozzi9
Copy link
Member

Replaces #20

Changes proposed in this pull request:

  • Replaced local ApiClient with AkeneoPimClient PHP SDK

@lruozzi9 lruozzi9 self-assigned this Mar 28, 2022
lruozzi9 added a commit that referenced this pull request Mar 28, 2022
@lruozzi9
Fix Spec tests (#125)
6756b83
@lruozzi9 lruozzi9 added the enhancement New feature or request label Mar 28, 2022
@lruozzi9 lruozzi9 added this to In progress in Release 2.0.0 via automation Mar 28, 2022
@lruozzi9 lruozzi9 added this to the v2.0.0 milestone Mar 28, 2022
lruozzi9 added a commit that referenced this pull request Mar 28, 2022
@lruozzi9
Remove ApiClient from UnitMeasurementValueConverter (#125)
7589e0a
lruozzi9 added a commit that referenced this pull request Mar 28, 2022
@lruozzi9
Remove ApiClientInterface from AttributeOptions Importer (#125)
3346481
@lruozzi9 lruozzi9 mentioned this pull request Mar 28, 2022
Closed
@lruozzi9 lruozzi9 marked this pull request as ready for review March 28, 2022 15:55
@lruozzi9 lruozzi9 moved this from In progress to Review in progress in Release 2.0.0 Mar 28, 2022
@lruozzi9 lruozzi9 marked this pull request as draft April 4, 2022 07:24
lruozzi9 added a commit that referenced this pull request Apr 4, 2022
@lruozzi9
Add CHANGELOG-2.0.md for API client replacement (#125)
7fd6003
@lruozzi9 lruozzi9 marked this pull request as ready for review April 4, 2022 09:22
LucaGallinari
LucaGallinari approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@LucaGallinari LucaGallinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

src/ValueHandler/FileAttributeValueHandler.php Show resolved Hide resolved
Release 2.0.0 automation moved this from Review in progress to Reviewer approved Apr 4, 2022
@lruozzi9
Copy link
Member Author

I have rebased this PR to the new master. There is some diff due to the PHP 8 refactoring, anyway I should have solved all the conflicts. The build is still red due to the BC breaks reported in CHANGELOG-2.0.md.

@lruozzi9 lruozzi9 merged commit dbfccb0 into master Apr 11, 2022
Release 2.0.0 automation moved this from Reviewer approved to Done Apr 11, 2022
lruozzi9 added a commit that referenced this pull request Apr 11, 2022
@lruozzi9
Fix Spec tests (#125)
65b8df4
lruozzi9 added a commit that referenced this pull request Apr 11, 2022
@lruozzi9
Remove ApiClient from UnitMeasurementValueConverter (#125)
09a4f85
lruozzi9 added a commit that referenced this pull request Apr 11, 2022
@lruozzi9
Remove ApiClientInterface from AttributeOptions Importer (#125)
98bae1c
@lruozzi9 lruozzi9 deleted the api-client-replacement-2 branch August 9, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaGallinari LucaGallinari LucaGallinari approved these changes

@mmenozzi mmenozzi Awaiting requested review from mmenozzi

Assignees

@lruozzi9 lruozzi9

Labels
enhancement New feature or request
Projects
No open projects
Release 2.0.0
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lruozzi9 @LucaGallinari