New: Change hint-axe to HintScope.any
#1301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `connector-local` uses `jsdom` it can support hints which need to evaluate script in the context of the page (e.g. `hint-axe`). Other hints with `HintScope.site` still need to remain that way as they look at HTTP headers or rely on external resources being loaded.
sarvaje
approved these changes
Sep 10, 2018
molant
approved these changes
Sep 11, 2018
molant
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
Now that
connector-localusesjsdomit can support hints whichneed to evaluate script in the context of the page (e.g.
hint-axe).Other hints with
HintScope.sitestill need to remain that way asthey look at HTTP headers or rely on external resources being
loaded.