New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hint-compat-api] Test against live sites #1574
Comments
To help, here's a pre-built bundle of the webhint browser extension with the compat-css and compat-css-next hints enabled:
An initial test against webhint.io definitely shows some noise we'll want to reduce. I'll file separate issues for each needed change. |
Here's another pre-built bundle with both the CSS and HTML hints enabled (based on current progress in #1584).
|
@antross should this be an Epic? Something else that is needed to close this? |
@molant No, just keeping this around to remind us to selfhost Since those changes are wrapping up in this milestone, we should all make a deliberate effort next week to selfhost, then merge #1596 when we're happy with the results. |
Fix webhintio#1574 Also fix support for multi-hints in `extension-browser`.
We may want to add the |
Ignore the
|
Fix webhintio#1574 Also fix support for multi-hints in `extension-browser`.
FYI: I have created #1797 to update the ignore list. |
I'm having some unexpected results on a site with bootstrap:
Let's pick the
If I go to the source, all the references to input[type="search"] {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
-webkit-appearance: none;
appearance: none
}
* {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box
}
*:before,*:after {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box
} I don't think the hint should be failing in this case. Am I wrong? |
I'm seeing the same and this shouldn't be failing. Let me update the pre-built bundle with the latest from |
Still repros for me with the latest from |
@borgitas21 do you still have time to look into this? |
Yes, I will check it. Could you provide the list of browsers you are using in this scenario? |
@borgitas21 We're using |
Fix webhintio#1574 Also fix support for multi-hints in `extension-browser`.
Before turning the new CSS and HTML versions of this hint on-by-default we should do some runs against live sites tracking what it reports to see if there are any obvious false-positives being flagged.
See PR #1596 for a pre-built browser extension bundle for testing.
The text was updated successfully, but these errors were encountered: