Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hint-compat-api] Test against live sites #1574

Closed
antross opened this issue Dec 12, 2018 · 13 comments · Fixed by #1596
Closed

[hint-compat-api] Test against live sites #1574

antross opened this issue Dec 12, 2018 · 13 comments · Fixed by #1596
Assignees
Milestone

Comments

@antross
Copy link
Member

antross commented Dec 12, 2018

Before turning the new CSS and HTML versions of this hint on-by-default we should do some runs against live sites tracking what it reports to see if there are any obvious false-positives being flagged.

See PR #1596 for a pre-built browser extension bundle for testing.

@antross
Copy link
Member Author

antross commented Dec 17, 2018

To help, here's a pre-built bundle of the webhint browser extension with the compat-css and compat-css-next hints enabled:

webhint-plus-mdn-css.zip (Removed - use newer version above)

An initial test against webhint.io definitely shows some noise we'll want to reduce. I'll file separate issues for each needed change.

@antross
Copy link
Member Author

antross commented Dec 28, 2018

Here's another pre-built bundle with both the CSS and HTML hints enabled (based on current progress in #1584).

webhint-plus-mdn-css-html.zip (Removed - use newer version above)

@molant molant added this to the 1901-02 milestone Jan 14, 2019
@molant
Copy link
Member

molant commented Jan 25, 2019

@antross should this be an Epic? Something else that is needed to close this?

@antross
Copy link
Member Author

antross commented Jan 25, 2019

@molant No, just keeping this around to remind us to selfhost hint-compat-api a bit more with the latest changes before turning it on-by-default.

Since those changes are wrapping up in this milestone, we should all make a deliberate effort next week to selfhost, then merge #1596 when we're happy with the results.

antross added a commit to antross/hint that referenced this issue Jan 25, 2019
Fix webhintio#1574

Also fix support for multi-hints in `extension-browser`.
@antross antross assigned antross and unassigned bruiztorres Jan 25, 2019
@antross antross modified the milestones: 1901-2, 1902-1 Jan 25, 2019
@antross antross changed the title [hint-compat-api] Add testing against live sites [hint-compat-api] Test against live sites Jan 28, 2019
@antross
Copy link
Member Author

antross commented Jan 28, 2019

We may want to add the crossorigin attribute to the built-in ignore list for HTML. It's often paired with the integrity attribute which we already ignore since SRI is a good thing to use even if not all your target browsers support it. That said, crossorigin can also be used in other contexts that don't involve integrity.

@antross
Copy link
Member Author

antross commented Jan 28, 2019

Ignore the spellcheck attribute. Falls back without functional impact.

global attribute spellcheck is not supported by samsunginternet_android 4, webview_android 4.4.3-4.4.4.

antross added a commit to antross/hint that referenced this issue Jan 29, 2019
Fix webhintio#1574

Also fix support for multi-hints in `extension-browser`.
@bruiztorres
Copy link
Contributor

bruiztorres commented Jan 30, 2019

FYI: I have created #1797 to update the ignore list.

@molant
Copy link
Member

molant commented Jan 31, 2019

I'm having some unexpected results on a site with bootstrap:

hint 1: viewport prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:518:1

hint 2: box-sizing prefixed with -webkit- is not supported by safari.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:15024

hint 3: box-sizing prefixed with -webkit- is not supported by safari.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:15120

hint 4: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:16040

hint 5: box-sizing prefixed with -webkit- is not supported by safari.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:35613

hint 6: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:36781

hint 7: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:53867

hint 8: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:82275

hint 9: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:84168

hint 10: animation prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:84988

hint 11: transform prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:105473

hint 12: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:105628

hint 13: transform prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:105790

hint 14: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:111294

hint 15: transition prefixed with -o- is not supported by opera 56-57.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:111604

Let's pick the box-sizing for example:

hint 2: box-sizing prefixed with -webkit- is not supported by safari.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:15024

hint 3: box-sizing prefixed with -webkit- is not supported by safari.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:15120

hint 5: box-sizing prefixed with -webkit- is not supported by safari.
https://repos.opensource.microsoft.com/css/bootstrap.min.css?4a:11:35613

If I go to the source, all the references to -webkit-box-sizing are:

input[type="search"] {
    -webkit-box-sizing: border-box;
    -moz-box-sizing: border-box;
    box-sizing: border-box;
    -webkit-appearance: none;
    appearance: none
}

* {
    -webkit-box-sizing: border-box;
    -moz-box-sizing: border-box;
    box-sizing: border-box
}

*:before,*:after {
    -webkit-box-sizing: border-box;
    -moz-box-sizing: border-box;
    box-sizing: border-box
}

I don't think the hint should be failing in this case. Am I wrong?

@antross
Copy link
Member Author

antross commented Jan 31, 2019

I'm seeing the same and this shouldn't be failing. Let me update the pre-built bundle with the latest from master and try again just to be sure.

@antross
Copy link
Member Author

antross commented Jan 31, 2019

Still repros for me with the latest from master.

@molant
Copy link
Member

molant commented Jan 31, 2019

@borgitas21 do you still have time to look into this?

@bruiztorres
Copy link
Contributor

Yes, I will check it. Could you provide the list of browsers you are using in this scenario?

@antross
Copy link
Member Author

antross commented Jan 31, 2019

@borgitas21 We're using defaults for browserslist.

antross added a commit to antross/hint that referenced this issue Feb 4, 2019
Fix webhintio#1574

Also fix support for multi-hints in `extension-browser`.
antross added a commit to antross/hint that referenced this issue Feb 7, 2019
antross added a commit to antross/hint that referenced this issue Feb 8, 2019
antross added a commit to antross/hint that referenced this issue Feb 8, 2019
antross added a commit to antross/hint that referenced this issue Feb 8, 2019
antross added a commit to antross/hint that referenced this issue Feb 8, 2019
@molant molant modified the milestones: 1902-1, 1902-2 Feb 11, 2019
antross added a commit to antross/hint that referenced this issue Feb 11, 2019
antross added a commit to antross/hint that referenced this issue Feb 11, 2019
antross added a commit to antross/hint that referenced this issue Feb 11, 2019
antross added a commit that referenced this issue Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants