Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Bump @types/vscode from 1.38.0 to 1.39.0 #3111

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps @types/vscode from 1.38.0 to 1.39.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Oct 12, 2019
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@molant
Copy link
Member

molant commented Oct 14, 2019

@antross looks like coverage suddenly dropped for the extension.Looks like it's analyzing the JS and not TS files so all the istanbul ignore comments don't work 😞

@molant
Copy link
Member

molant commented Oct 14, 2019

@antross just pushed a commit that should fixe the issue. Can you take a look when you have the time?

@antross
Copy link
Member

antross commented Oct 15, 2019

@molant I guess that means ava is having trouble following source maps for the webpack build, even with mode set to development.

Maybe we should just drop the build:webpack command and leave the test command as it was before? We really only need to use webpack for the release build anyway and build-release already has its own call.

@antross
Copy link
Member

antross commented Oct 15, 2019

Maybe we should just drop the build:webpack command and leave the test command as it was before?

Nevermind, that would break debugging with VS Code as we point to the bundle folder. Your change is probably best as-is.

@molant
Copy link
Member

molant commented Oct 15, 2019

@antross can this be merged then?

@molant molant merged commit 2517e0c into master Oct 15, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/types/vscode-1.39.0 branch October 15, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants