Enable strict mode of TypeScript

[molant]

Should we enable "strict": true in tsconfig.json?

I've tried running it and there are quite a few things to fix, but might be better in the long-term for the project.

@alrra, @sarvaje @qzhou1607 ?

[sarvaje]

👍

[molant]

Looks like there's agreement so removing the question label

[sarvaje]

@molant @alrra do you want me to start doing this?

[molant]

Making a list of all the things that need someone to work on or where there are currently some issues

package	owner	comments
create-hint	@molant	Issue with appinsights Namespace '"http"' has no exported member 'ServerRequest'.
create-hintrc	@molant	Issue with appinsights Namespace '"http"' has no exported member 'ServerRequest'.
create-parser	@molant	Issue with appinsights Namespace '"http"' has no exported member 'ServerRequest'. Also I think there's something broken in the logic of the package
connector-chrome	@sarvaje
connector-jsdom	@antross
parser-babel-config	@antross
parser-javascript	@antross
parser-manifest	@antross
parser-typescript-config	@antross
parser-webpack-config	@antross
utils-connector-tools	@antross
utils-debugging-protocol-common	@antross

@antross, @sarvaje if you can update this table when you grab one it would be awesome.

Thanks!

[molant]

All the packages that are not listed above are already done and merged or waiting to be merged.

[sarvaje]

Issue with appinsights Namespace '"http"' has no exported member 'ServerRequest'.

@molant that happens because of the version of @types/node. I had the same problem in the online scanner and the solution was fix the version of that package.

[molant]

@sarvaje I've updated to appinsights 1.0.5 and that seems to solve the problem.

[molant]

I've updated to appinsights 1.0.5 and that seems to solve the problem.

I had to pin to @types/node to 10.9.1 to make it work 😔

[molant]

Looks like the remaining thing is the code under scripts 🎉