Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Fully enable strict mode for the project #1382

Closed
wants to merge 56 commits into from
Closed

Chore: Fully enable strict mode for the project #1382

wants to merge 56 commits into from

Conversation

antross
Copy link
Member

@antross antross commented Oct 8, 2018

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Fixes #576.

Combines PRs #1372, #1373, and #1377.

This was referenced Oct 8, 2018
Closed
Closed
Closed
@antross
Chore: Build hint-disown-opener in strict mode
ebedffd
@antross
Chore: Build highest-available-document-mode in strict mode
2dc1f8c
@antross
Chore: Build hint-html-checker in strict mode
f3ddfdc
@antross
Chore: Build hint-http-cache in strict mode
7152bf7
@antross
Chore: Build hint-http-compression in strict mode
70cbf5a
@antross
Chore: Build hint-image-optimization-cloudinary in strict mode
0b09651
@antross
Chore: Build hint-manifest-app-name in strict mode
e53bd9f
@antross
Chore: Build hint-manifest-exists in strict mode
8d8746a
@antross
Chore: Build hint-manifest-file-extension in strict mode
ac7dabc
@antross
Chore: Build hint-manifest-is-valid in strict mode
8c91ff1
@antross
Chore: Build hint-meta-charset-utf-8 in strict mode
52f243b
@antross
Chore: Build hint-meta-theme-color in strict mode
a65fabf
@antross
Chore: Build hint-meta-viewport in strict mode
75aa030
@antross
Chore: Build hint-minified-js in strict mode
801d2b0
@antross
Chore: Build hint-no-bom in strict mode
47e9b14
@antross
Chore: Build hint-no-disallowed-headers in strict mode
0d896e9
@antross
Chore: Build hint-no-friendly-error-pages in strict mode
0acbf41
@antross
Chore: Build hint-no-html-only-headers in strict mode
7dd6b56
@antross
Chore: Build hint-no-http-redirects in strict mode
c438d8e
@antross
Chore: Build hint-no-p3p in strict mode
e4ebff8
@antross
Chore: Build hint-no-protcol-relative-urls in strict mode
1d2feb6
@antross
Chore: Build hint-no-vulnerable-javascript-libraries in strict mode
ed03f6e
@antross
Chore: Build hint-performance-budget in strict mode
ea5ddb7
antross and others added 25 commits October 8, 2018 15:49
@antross
Chore: Build utils-connector-tools in strict mode
19c4174
@antross
Chore: Build utils-debugging-protocol-common in strict mode
5cf9de0
@antross
Chore: Build connector-jsdom in strict mode
5f104a4 
Focused more on compiling vs. fully correct types.
@sarvaje @antross
Chore: Build connector-chrome in strict mode
7c8a4c0
@molant @antross
Chore: Build hint-x-content-type-options in strict mode
9c246a8
@molant @antross
Chore: Build hint-webpack-config in strict mode
983176b
@molant @antross
Chore: Build hint-validate-set-cookie-header in strict mode
e5575e8
@molant @antross
Chore: Build hint-typescript-config in strict mode
ff27564
@molant @antross
Chore: Build formatter-codeframe in strict mode
0b40f93
@molant @antross
Chore: Build formatter-excel in strict mode
1e9d785
@molant @antross
Chore: Build formatter-json in strict mode
503fae7
@molant @antross
Chore: Build formatter-stylish in strict mode
9ab71bc
@molant @antross
Chore: Build formatter-summary in strict mode
c3ab1e9
@molant @antross
Chore: Build create-hintrc in strict mode
1b46b1e
@molant @antross
Chore: Build create-hint in strict mode
014e68d
@molant @antross
Chore: Build create-parser in strict mode
ce2ea56
@molant @antross
Chore: Issue with promisify
8d66564
@molant @antross
Chore: Enable strict mode globally
176bdf4
@antross
Chore: Build connector-edge in strict mode
3ce2745
@antross
Chore: Include types needed for release.ts in strict mode
4820ed2
@antross
Chore: Don't build connector-edge with full project
a723d87
@antross
Chore: Build release.ts in strict mode
ceef002
@antross
Chore: Fix test regression in hint-x-content-type-options
482a09d
@antross
Chore: Remove extra line from hint-typescript-config
e038aca
@antross
Chore: Use type instead of interface in release.ts
0336d83
@antross
Copy link
Member Author

antross commented Oct 9, 2018

@alrra and @molant, anything else needed before we can merge this in?

molant
molant approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The history is clean enough that I don't think is worth trying to put the last 2 commits in the right place squashed.

@alrra do you want to take a look or are you ok?

@alrra alrra closed this in 8d2a9e3 Oct 9, 2018
@molant molant deleted the remaining-strict-mode branch October 11, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molant molant molant approved these changes

@sarvaje sarvaje sarvaje approved these changes

@alrra alrra Awaiting requested review from alrra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable strict mode of TypeScript
3 participants
@antross @molant @sarvaje