Chore: Build packages/hint in strict mode
#1356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
reviewed
Oct 1, 2018
| import getFileExtension from './fs/file-extension'; | ||
| import getFileName from './fs/filename'; | ||
| import normalizeString from './misc/normalize-string'; | ||
|
|
||
| const mimeDB = require('mime-db'); |
There was a problem hiding this comment.
Maybe add a comment here like in the other requires?
There was a problem hiding this comment.
Actually this one shouldn't have been changed as it doesn't fit the same pattern (it returns an object). It was leftover from a search for better types so I'll change it back since the modern syntax is fine for this one.
antross
force-pushed
the
strict-mode-hint
branch
from
333e6e1
to
718114f
Compare
molant
reviewed
Oct 4, 2018
| @@ -4,7 +4,7 @@ | |||
| import { CLIOptions } from '../types'; | |||
|
|
|||
| /** Wrapper to dynamically load the different CLI tasks depending on a condition */ | |||
| const action = (pkg: string, condition?: string): (actions: CLIOptions) => Promise<boolean> => { | |||
| const action = (pkg: string, condition?: keyof CLIOptions): (actions: CLIOptions) => Promise<boolean> => { | |||
| @@ -388,7 +388,7 @@ export class Configuration { | |||
| } | |||
|
|
|||
| // In case the user uses the --watch flag when running hint | |||
| if (actions && actions.watch) { | |||
| if (actions && actions.watch && userConfig.connector && userConfig.connector.options) { | |||
There was a problem hiding this comment.
🤞 that https://github.com/tc39/proposal-optional-chaining will advance stage 1 one day so we can avoid this type of code.
Aligns the types with what was already supported in code. This was breaking using strict in callers from other packages.
Will be re-introduced in a separate commit.
No longer restricts to `NamedNodeMap` of which most methods are unused, but instead allows any object implementing the `length` property with either an `item()` method or an index signature, the latter of which supports `Array`s.
Aligns with `IConnectorConstructor`.
Aligns with `IConnectorConstructor`.
This intermittently fails - the complex method signature seems to confuse the TypeScript compiler depending on some unknown piece of state. Ok treating as `any` for tests.
Also ignore some fallback cases in coverage.
antross
force-pushed
the
strict-mode-hint
branch
from
f044736
to
54dd77f
Compare
3 tasks
|
@antross Good job! 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Added/Updated related documentation.Short description of the change(s)
Sets
"strict": trueinpackage.jsonforpackages/hint.Builds, but branch coverage is currently below threshold for tests.
Also still chasing down breaks in dependent packages caused by this work.